Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sort select background in dark mode #1427

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fish-404
Copy link

Fix sort select background in dark mode in order to see the text clearly.

image

@fish-404 fish-404 requested a review from umputun as a code owner July 22, 2022 01:20
@umputun umputun requested a review from akellbl4 July 22, 2022 01:21
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #1427 (1e90990) into master (5db6e43) will not change coverage.
The diff coverage is n/a.

❗ Current head 1e90990 differs from pull request most recent head 53b424a. Consider uploading reports for the commit 53b424a to get more accurate results

@@           Coverage Diff           @@
##           master    #1427   +/-   ##
=======================================
  Coverage   58.12%   58.12%           
=======================================
  Files         131      131           
  Lines        2909     2909           
  Branches      743      743           
=======================================
  Hits         1691     1691           
  Misses       1087     1087           
  Partials      131      131           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5db6e43...53b424a. Read the comment docs.

@akellbl4
Copy link
Collaborator

@fish-404 hey, thanks for contribution. I'm curious what browser renders select dropdown like so?

@fish-404
Copy link
Author

@fish-404 hey, thanks for contribution. I'm curious what browser renders select dropdown like so?

@akellbl4 Hey, I use Firefox 100.0.2, inspect the default background-color is rgb(233, 233, 237).

Take Edge and Chrome to test, their default background-color is rgb(255, 255, 255) which can see the text clearly.

@akellbl4
Copy link
Collaborator

akellbl4 commented Jul 22, 2022

Is it on Windows?
Also, do you have color-scheme property in css on your site?

@akellbl4
Copy link
Collaborator

I've checked the problem. It should be fixed in slightly different way. The problem is in color-scheme. We have an issue connected with it #1430
Can you help with it?

@fish-404
Copy link
Author

I've checked the problem. It should be fixed in slightly different way. The problem is in color-scheme. We have an issue connected with it #1430 Can you help with it?

OK, but I'm not sure if I am able to help, will check it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants