Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for giving a single score for the whole object #295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aguscas
Copy link
Collaborator

@aguscas aguscas commented Feb 9, 2024

Creating an array of scores might be a little annoying considering that is quite common to only have a single score for the whole detection. This modification is to allow the user to provide either a single number (float or int) or a numpy array of scores.

Copy link
Collaborator

@javiber javiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a single question regarding the points doc change

@@ -746,7 +746,7 @@ class Detection:
Parameters
----------
points : np.ndarray
Points detected. Must be a rank 2 array with shape `(n_points, n_dimensions)` where n_dimensions is 2 or 3.
Points detected. Must be a rank 2 array with shape `(n_points, n_dimensions)`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did this change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thing is that it is not actually a restriction to have dimension 2 or 3. You can have any dimension you want. I decided to change that description since I was already modifying the Detection class anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants