Upgrade to Vue 3 and Vite #144
Conversation
- Add new sample manifest with fulltext and associated files - Add API routes for locally handling annotation lists and annotations - Update invalid files for testing
Upgrade to Vue 3 with Vite as build tool. Components keep the old options API, while the composition API is used in imported modules. Looks and functionality remain unchanged. - Replace mixins with modules, using named imports - Rename files and lint everything according to the latest Vue coding style - Update all packages to their latest version, except OpenSeadragon - Use Vitest instead of Jest for unit tests (Vue recommendation) - Remove the last remnants of support for Internet Explorer - Improve HTML templates - Rewrite and extend tests
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
The actual error message is different on each browser, so make the test more generic.
We actually want version 3.0.0, not 3.1.0, which introduced a small but annoying bug.
t11r
force-pushed
the
vue3
branch
4 times, most recently
from
4bd0c3e
to
f926cb4
Compare
t11r
force-pushed
the
vue3
branch
6 times, most recently
from
9f39a2a
to
515341f
Compare
ipf
force-pushed
the
vue3
branch
3 times, most recently
from
abdaae5
to
e791938
Compare
- Enable display of multiple error messages - Add ARIA attribute
- Allow configuration of the local IIIF server port so multiple servers can run at the same time - Extend collections tests to check if multiple child manifests can be loaded successively - Add basic tests for TIFY's API
Update all packages to their latest minor version (except OpenSeadragon), remove unused packages.
And add a manifest URL input.
Use ResizeObserver instead of an event handler. Not only does this make the code more concise, but also reacts to changes of the element size when the window size stays the same.
- Add close-all button - Improve styling
|
🎉 |
- Replace instance-dependent modules with globally available plugins to restore multi-instance functionality - Move all functions from main to App for better testability - Fix text flashing in fulltext panel - Fix translations in help panel - Improve coding style - Improve unit tests
package.json
Outdated
| "eslint-plugin-vue": "^9.14.1", | ||
| "jsdom": "^21.1.2", | ||
| "openseadragon": "3.0.0", | ||
| "sass": "^1.62.1", |
There was a problem hiding this comment.
Do we still need "sass" as dep?
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah ok, somehow the build still succeeded for me when I tried to remove "sass".
|
Another issue I found is this: With this error on the console: It seems that they use |
|
Good find, thanks! There are actually two bugs in the collection view, one regarding the |
|
|
|
Maybe give it a default label like "Manifest 1", "Manifest 2" and only if something useful (label/description) exists in the response, overwrite it. This could also work for collection labels. |
|
Too much code just for displaying an invalid manifest. I’m just making sure the app does not break. |
Although invalid IIIF, there are collection manifests in the wild with missing labels, and we don’t want them to make TIFY crash.
|
looks ok to me |
Update all dependencies to their latest minor version, except OpenSeadragon. Remove obsolete packages: - sass - vitest-canvas-mock
Should be ready for release now.