Game registration refactor and improvements #4
Conversation
This module will eventually make it possible for linux-native hosts to query information from the wine prefix's registry in a way that is 1:1 to windows.
This commit primarily includes a major refactor of game import routines. It increases the extensibility of the system at the cost of a vtable (Box<dyn GameImporter>) and overall system complexity. The hope is that this refactor will make it easier to: - a: Add new platforms or platform subvariants (SteamDirect, for example) - b: Add wine subsystem support for linux-native hosts. This also includes a first swing at "unrolling" the monolithic error type at crate::error::Error, replacing it with mod-specific error impls. This should *theoretically* increase general code quality by de-incentivising a "bubble up" approach to error handling. By allowing more granular control over error variants, callees can have more control over handling recoverable error states.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ethangreen-dev
force-pushed
the
game-reg-improvements
branch
from
2929b59
to
5283a01
Compare
| todo!() | ||
| } | ||
|
|
||
| pub fn get_value_at(hkey: HKey, subkey: &str, name: &str) -> Result<String, Error> { |
Check warning
Code scanning / clippy
unused variable: hkey Warning
| todo!() | ||
| } | ||
|
|
||
| pub fn get_value_at(hkey: HKey, subkey: &str, name: &str) -> Result<String, Error> { |
Check warning
Code scanning / clippy
unused variable: subkey Warning
| todo!() | ||
| } | ||
|
|
||
| pub fn get_value_at(hkey: HKey, subkey: &str, name: &str) -> Result<String, Error> { |
Check warning
Code scanning / clippy
unused variable: name Warning
| todo!() | ||
| } | ||
|
|
||
| pub fn get_keys_at(hkey: HKey, subkey: &str) -> Result<Vec<String>, Error> { |
Check warning
Code scanning / clippy
unused variable: hkey Warning
| todo!() | ||
| } | ||
|
|
||
| pub fn get_keys_at(hkey: HKey, subkey: &str) -> Result<Vec<String>, Error> { |
Check warning
Code scanning / clippy
unused variable: subkey Warning
| todo!() | ||
| } | ||
|
|
||
| pub fn get_values_at(hkey: HKey, subkey: &str) -> Result<Vec<RegKeyVal>, Error> { |
Check warning
Code scanning / clippy
unused variable: hkey Warning
| todo!() | ||
| } | ||
|
|
||
| pub fn get_values_at(hkey: HKey, subkey: &str) -> Result<Vec<RegKeyVal>, Error> { |
Check warning
Code scanning / clippy
unused variable: subkey Warning
No description provided.