Editorial: Add assertion that generatorKind is not non-generator #3379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmdyck
reviewed
Jul 30, 2024
| @@ -24084,6 +24084,7 @@ <h1>Runtime Semantics: Evaluation</h1> | |||
| <emu-grammar>YieldExpression : `yield` `*` AssignmentExpression</emu-grammar> | |||
| <emu-alg> | |||
| 1. Let _generatorKind_ be GetGeneratorKind(). | |||
| 1. Assert: _generatorKind_ is not ~non-generator~. | |||
There was a problem hiding this comment.
I think this is correct. However, rather than the double negative of "not non-generator", it might be clearer to make the positive assertion:
Suggested change
| 1. Assert: _generatorKind_ is not ~non-generator~. | |
| 1. Assert: _generatorKind_ is either ~sync~ or ~async~. |
There was a problem hiding this comment.
I agree with you. Thanks for making this clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to runtime semantics of
_YieldExpression_ : yield * _AssignmentExpression_evaluation,_generatorKind_is NON-GENERATOR, SYNC, or ASYNC. However, the type of second parameter ofGetIteratoris SYNC or ASYNC in current specification. This is type-mismatch. I thinkGetGeneratorKindcannot return NON-GENERATOR in this case, so this PR includes adding assertion thatgeneratorKindis not NON-GENERATOR.