PHP7 Compatibility release #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wait for @nitriques to merge it |
nitriques
added a commit
that referenced
this pull request
Jun 20, 2017
This is required for compatibility with Symphony 2.7.x, which bring compatibility with MySQL 5.7 strict mode. The code is a copy of the logic from buildSortingSQL, which should be refactored when dropping pre 2.7.0 compatibility Re: #84
|
Can you please rebase ? |
nitriques
requested changes
Oct 1, 2018
extension.meta.xml
Outdated
| @@ -15,6 +15,12 @@ | |||
| </author> | |||
| </authors> | |||
| <releases> | |||
| <release version="3.0.0" date="TBA" min="4.0.0" max="4.x.x" php-min="5.6.x" php-max="7.x.x"> | |||
There was a problem hiding this comment.
Can we change to min="3.0.0" ?
added 14 commits
October 2, 2018 09:15
PHP true,false,null in lowercase SQL keywords uppercase
Remove temporary buildSortingSelectSQL function.
nitriques
requested changes
Oct 3, 2018
| @@ -1,6 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <extension id="selectbox_link_field" status="released" xmlns="http://getsymphony.com/schemas/extension/1.0"> | |||
| <name>Select Box Link Field</name> | |||
| <name>Field: Select Box Link</name> | |||
| <description>Linking two sections together</description> | |||
| <repo type="github">https://github.com/symphonycms/selectbox_link_field</repo> | |||
| <url type="discuss">https://getsymphony.com/discuss/thread/473/</url> | |||
There was a problem hiding this comment.
Can you please make it https://www...
There was a problem hiding this comment.
Can you be more specific ? @nitriques
extension.meta.xml
Outdated
| @@ -15,6 +15,12 @@ | |||
| </author> | |||
| </authors> | |||
| <releases> | |||
| <release version="3.0.0" date="TBA" min="3.0.0" max="4.x.x" php-min="5.6.x" php-max="7.x.x"> | |||
| - Update for Symphony 4.x | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.