[0.x] Add mare to ci (#29)

symblaze · Jul 20, 2024 · fc85a2a · fc85a2a
1 parent db97725
commit fc85a2a
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -33,6 +33,10 @@ jobs:
         run: "composer cs-check"
         if: matrix.operating-system == 'ubuntu-latest'
 
-      - name: "Static code analysis"
+      - name: "Psalm Static Analysis"
         run: "composer psalm"
         if: matrix.operating-system == 'ubuntu-latest'
+
+      - name: "Mare Static Analysis"
+        run: "composer mare"
+        if: matrix.operating-system == 'ubuntu-latest'
diff --git a/composer.json b/composer.json
@@ -14,7 +14,8 @@
     "psalm": "vendor/bin/psalm --no-cache",
     "psalm-t": "vendor/bin/psalm --no-cache --output-format=compact",
     "cs-check": "vendor/bin/php-cs-fixer fix --dry-run --diff --verbose",
-    "cs-fix": "php-cs-fixer fix --verbose"
+    "cs-fix": "php-cs-fixer fix --verbose",
+    "mare": "./bin/run scan"
   },
   "bin": [
     "bin/run"

diff --git a/src/Console/ConfigFinder.php b/src/Console/ConfigFinder.php
@@ -14,7 +14,7 @@ class ConfigFinder
      */
     public function find(string $configOption, string $workDir): Config
     {
-        $configPath = empty($configOption) ? $workDir.'/.mare_scan.php' : $configOption;
+        $configPath = '' === $configOption ? $workDir.'/.mare_scan.php' : $configOption;
 
         if (! file_exists($configPath)) {
             throw ConfigNotFoundException::create($configPath);

diff --git a/src/Console/ScanCommand.php b/src/Console/ScanCommand.php
@@ -46,7 +46,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         $progressBar->finish();
 
-        return empty($result) ? $this->exitSuccess() : $this->exitError($result);
+        return 0 === count($result) ? $this->exitSuccess() : $this->exitError($result);
     }
 
     private function findConfiguration(InputInterface $input): Config