-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI repair #157
base: main
Are you sure you want to change the base?
CI repair #157
Conversation
The previous certs had expired. Fixes: swift-server-community#156
Resolves ci-time warnings.
Also use release 5.10 image in matrix.
I'm wondering if a better solution is to generate new certs in the GitHub action so they never expire for CI. |
Also codecov wasn't even enabled on this repo, when it got moved to swift-server-community. You might as well up the version number on the action and I'll see if I can fix it |
This requires a CODECOV_TOKEN secret be configured for the GitHub repo as described here: https://docs.codecov.com/docs/adding-the-codecov-token
Added the change for codecov. You'll need to define a |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
- Coverage 79.07% 78.12% -0.96%
==========================================
Files 22 22
Lines 2518 1979 -539
==========================================
- Hits 1991 1546 -445
+ Misses 527 433 -94 ☔ View full report in Codecov by Sentry. |
That's an idea. Given the trouble I had with needing to use MacOS' libreSSL versus homebrew's OpenSSL, it might be that the |
actions/checkout@v4
(resolves GitHub deprecation warning)N.B. there remains a GitHub deprecation warning related to
codecov/codecov-action@v2
, which uses an out of date version of node. But to migrate tocodecov/codecov-action@v4
requires setting up a codecov token as described here, which requires a repo admin permissions.