Support bytes schema for the lakehouse connector #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- Fixes: #60 *Motivation* Support bytes schema for the lakehouse connector. We construct the PulsarObject for saving the primitive schema(currently only have bytes and string). The message with primitive schema will write into the lakehouse table with key name 'message' by default. You can change the name according to the configuration.
hangc0276
reviewed
Jun 29, 2022
| object = new PulsarObject<>((String) value, Schema.create(Schema.Type.STRING)); | ||
| break; | ||
| default: | ||
| throw new RuntimeException("Failed to build pulsar object, the given type '" + schemaType + "' " |
There was a problem hiding this comment.
We need to support all primitive type that Pulsar supported.
There was a problem hiding this comment.
I'm not sure if it needs to support INT, BOOLEAN or DOUBLE. Because it looks useless to save an int or boolean into the table. so I want to support it when there has someone who wants it.
There was a problem hiding this comment.
I created an issue to track it. We can support String and Byte first. If there is requests in the future, we can support other primitive types.
| public PulsarObject(T value, Schema schema) { | ||
| this.value = value; | ||
| valueSchema = schema; | ||
| this.uuid = UUID.randomUUID().toString(); |
There was a problem hiding this comment.
What's the meaning of uuid?
There was a problem hiding this comment.
UUID is used as the partition key for the hudi table
hangc0276
approved these changes
Jun 30, 2022
zymap
added a commit
that referenced
this pull request
Jul 12, 2022
--- Fixes: #60 *Motivation* Support bytes schema for the lakehouse connector. We construct the PulsarObject for saving the primitive schema(currently only have bytes and string). The message with primitive schema will write into the lakehouse table with key name 'message' by default. You can change the name according to the configuration. (cherry picked from commit 946ef80)
zymap
added a commit
that referenced
this pull request
Jul 12, 2022
--- Fixes: #60 *Motivation* Support bytes schema for the lakehouse connector. We construct the PulsarObject for saving the primitive schema(currently only have bytes and string). The message with primitive schema will write into the lakehouse table with key name 'message' by default. You can change the name according to the configuration. (cherry picked from commit 946ef80)
zymap
added a commit
that referenced
this pull request
Jul 12, 2022
--- Fixes: #60 *Motivation* Support bytes schema for the lakehouse connector. We construct the PulsarObject for saving the primitive schema(currently only have bytes and string). The message with primitive schema will write into the lakehouse table with key name 'message' by default. You can change the name according to the configuration. (cherry picked from commit 946ef80)
hangc0276
added a commit
that referenced
this pull request
Jul 25, 2022
--- Fixes: #60 *Motivation* Support bytes schema for the lakehouse connector. We construct the PulsarObject for saving the primitive schema(currently only have bytes and string). The message with primitive schema will write into the lakehouse table with key name 'message' by default. You can change the name according to the configuration. (cherry picked from commit 946ef80)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #60
Motivation
Support bytes schema for the lakehouse connector.
We construct the PulsarObject for saving the primitive schema(currently only
have bytes and string). The message with primitive schema will write into the
lakehouse table with key name 'message' by default. You can change the name
according to the configuration.