Fix compilation error in spi.rs for rust Version 1.73+ #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: I have not tested this on hardware, just added the allow attribute. Also see [this](rust-lang/rust#116410) issue
|
See also stm32-rs/stm32f7xx-hal#207 and stm32-rs/stm32f3xx-hal#346 which had the same problem and a couple other options for fixing it. |
This was referenced Nov 25, 2023
This was referenced Dec 7, 2023
|
@JanekGraff Thanks for trying to fix this. Would you mind changing to Unrelated nit: Could you please remove the added newlines between the links in the CHANGELOG.md? |
Sure thing, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With rust version 1.73.0 the
invalid_reference_castinglint was set to deny by default. (See PR#112431. This causes the build process of this crate to fail to build spi.rs (only when building the crate with its examples, when adding it as a dependency works fine from what i can see).This change fixes the compilation by adding the
[allow(invalid_reference_casting)]attribute to the relevant parts.This also fixes a
unused doc commentcompilation warning in rcc.rsNOTE
I have not tested this on hardware, just added the attribute to fix the compilation.