Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default config for MacOS #120

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kanha-gupta
Copy link

@kanha-gupta kanha-gupta commented Feb 19, 2023

issue:- #109

I have used the macOS "which" command to check if an IDE is installed in the users path.
Please review the code if its appropriate or should i resort to using path_env.contains or Files.exist method
PS- build was successful after changes
Thank you ! :)

@fahad-israr
Copy link
Collaborator

@kanha-gupta did u test this too? if yes what version of macos did u test on?

@kanha-gupta
Copy link
Author

@fahad-israr Nope, i wanted to but Don't have access to MacOS right now,
Does testing on a macOS VM or docker container works ?

@fahad-israr
Copy link
Collaborator

should be good but just need to make sure it works atleast once on a real system. try if you can else at last I'll test on my machine .

@kanha-gupta
Copy link
Author

I am highly Doubtful if i can arrange a Mac in a short time frame.
Would be alot of help if You can test it :)
Thanks alot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants