Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update current_timestamp macro to precision 6 with time zone #204

Closed
wants to merge 3 commits into from
Closed

Update current_timestamp macro to precision 6 with time zone #204

wants to merge 3 commits into from

Conversation

RobbertDM
Copy link
Contributor

@RobbertDM RobbertDM commented Dec 29, 2022 •
edited
Loading

Overview

This PR changes the current_timestamp macro to use

  • precision 6, making it compatible with the iceberg file format
  • a time zone, making it explicit that the timestamp stored in snapshots is a UTC timestamp

Trouble described here: #126
But also here: dbt-labs/dbt-core#5867

Checklist

  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • README.md updated and added information about my change
  • I have run changie new to create a changelog entry

@RobbertDM RobbertDM mentioned this pull request Dec 29, 2022
Open
1 task
@mdesmet mdesmet closed this Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobbertDM @mdesmet