Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove async templates #50

Merged
merged 24 commits into from
Feb 20, 2024
Merged

refactor: remove async templates #50

merged 24 commits into from
Feb 20, 2024

Conversation

sohnj877
Copy link
Collaborator

@sohnj877 sohnj877 commented Feb 15, 2024

  1. Replace async() with include()
  2. Delete async_templates_script()
  3. Fixed z-index issue with the pagination + footer
  4. Fixed tooltip dropdown clickable when hidden
  5. Replace /s/api/v1/resource with SDK getResource
  6. Fixed mini cart pricing

@sohnj877 sohnj877 changed the title Remove async_templates_script() Refactor: remove async_templates_script() Feb 15, 2024
@sohnj877 sohnj877 changed the title Refactor: remove async_templates_script() refactor: remove async_templates_script() Feb 15, 2024
@sohnj877 sohnj877 changed the title refactor: remove async_templates_script() refactor: remove async templates Feb 15, 2024
@sohnj877 sohnj877 merged commit 5b659b8 into alpha Feb 20, 2024
3 checks passed
@sohnj877 sohnj877 deleted the remove-async branch February 20, 2024 20:40
@kchung
Copy link
Collaborator

kchung commented Feb 20, 2024

Ah shoot, this didn't seem like it created a version bump because it was considered a refactor

Copy link

🎉 This PR is included in version 1.0.0-alpha.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

sohnj877 added a commit that referenced this pull request Feb 26, 2024
…x-search-500

* 'alpha' of https://github.com/square/brisk-theme: (66 commits)
  feat(async): release async template removal (#53)
  refactor: remove async templates (#50)
  ci(github-action): use latest version of checkout action (#49)
  ci(github-actions): fix commitlint help url config (#48)
  ci(github-actions): add commit linting (#47)
  docs: update theme version (#46)
  fix: banner image missing on shop all (#45)
  refactor(home): update home sections (#43)
  chore: update hooks (#42)
  docs: add contributing file (#41)
  build(github-actions): update job action versions (#40)
  build(github-actions): add lint action (#39)
  build(release): add semantic releases (#38)
  Fix link control
  Update page to use lowercase value
  Fix header controls
  fix: typo
  refactor: use twig image filter
  Update gitignore
  Provide default image
  ...
sohnj877 added a commit that referenced this pull request Feb 26, 2024
…x-search-500

* 'alpha' of https://github.com/square/brisk-theme: (66 commits)
  feat(async): release async template removal (#53)
  refactor: remove async templates (#50)
  ci(github-action): use latest version of checkout action (#49)
  ci(github-actions): fix commitlint help url config (#48)
  ci(github-actions): add commit linting (#47)
  docs: update theme version (#46)
  fix: banner image missing on shop all (#45)
  refactor(home): update home sections (#43)
  chore: update hooks (#42)
  docs: add contributing file (#41)
  build(github-actions): update job action versions (#40)
  build(github-actions): add lint action (#39)
  build(release): add semantic releases (#38)
  Fix link control
  Update page to use lowercase value
  Fix header controls
  fix: typo
  refactor: use twig image filter
  Update gitignore
  Provide default image
  ...
sohnj877 added a commit that referenced this pull request Mar 28, 2024
…ore-locator

* 'alpha' of https://github.com/square/brisk-theme: (52 commits)
  feat: use system page properties (#52)
  fix: rename 'option' to 'control' in section controls (#59)
  refactor: rename 'option' to 'control' in section controls (#57)
  fix: search result 500 (#54)
  fix: respond to breaking changes (#55)
  feat(async): release async template removal (#53)
  refactor: remove async templates (#50)
  ci(github-action): use latest version of checkout action (#49)
  ci(github-actions): fix commitlint help url config (#48)
  ci(github-actions): add commit linting (#47)
  docs: update theme version (#46)
  fix: banner image missing on shop all (#45)
  refactor(home): update home sections (#43)
  chore: update hooks (#42)
  docs: add contributing file (#41)
  build(github-actions): update job action versions (#40)
  build(github-actions): add lint action (#39)
  build(release): add semantic releases (#38)
  Fix link control
  Update page to use lowercase value
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants