-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add option to prepend or append Pythonpath Manager paths to sys.path #21769
base: master
Are you sure you want to change the base?
Conversation
Hello @mrclary! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-09-12 14:44:56 UTC |
3999697
to
3c2c64d
Compare
b11ccad
to
a433e97
Compare
5f68078
to
ffd9395
Compare
0a04027
to
73e407e
Compare
Remove SPY_PYTHONPATH; run update_syspath on setup_spyder_kernel. I think this would be much cleaner if the the emitted signal carried old/new spyder_pythonpath instead of the dictionary. I don't know of any plugin listening for sig_pythonpath_changed that requires the dictionary version.
test_ipythoncosonle.py had many failures on latest master; attempting CI=1 skipped many tests but hangs on test_pdb_ignore_lib[True]
…_paths, system_paths) and dictionary type
…pdate_paths method and call setup in update-paths method. This will allow the container to instantiate the PathManager widget before providing paths. Paths will not be retrieved or determined within the widget, only passed to it by the container.
These will be dictionaries and the container will handle updating the pythonpath_manager configuration and assembling the final spyder_pythonpath. There is no need for _update_system_path method because the container will handle updates to the underlying system path. Again, the widget will only handle user-interactive changes.
This will be done in the container instead.
…oritize) -> (_user_paths, _system_paths, _project_paths, _prioritize, _spyder_pythonpath). Path lists are now OrderedDict * Simplifies _load_pythonpath -> _load_paths * Move migration method from setup to _load_paths
* Promptly exits if remnants of old configuration are not present * Removes remnants of old configuration if present * Constructs user paths from old configuration remnants
* Configuration keys and private attributes for user paths, system paths, prioritize, and spyder_pythonpath are set conditionally in this method and nowhere else. * sig_pythonpath_changed is conditionally emitted from this method and nowhere else. This signal now sends only the spyder_pythonpath and prioritize, not the old spyder_pythonpath. Subscribers should update accordingly.
…ardly constructed from project, user, and system paths attributes.
…d in _save_paths if spyder_pythonpath is changed.
…d in PathManager.updat_paths
… Note that spyder-kernels must be updated to accommodate.
Icon and tooltip are changed to reflect current state.
Co-authored-by: Jitse Niesen <[email protected]> Typographical errors. Improved docstring clarity
The desired affect is project paths | user paths | system paths, where the paths are in that order and are overwritten in that order. System paths cannot overwrite user paths, which cannot overwrite project paths, i.e we cannot just do project_paths.update(user_paths) etc.
…lary/spyder-kernels.git --update --force external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "33db307c9" upstream: origin: "https://github.com/mrclary/spyder-kernels.git" branch: "ppm-syspath" commit: "33db307c9" git-subrepo: version: "0.4.9" origin: "???" commit: "???"
d1d642e
to
36a68d8
Compare
Description of Changes
Primary Changes
Added toggle button to Pythonpath Manager dialog that determines whether active paths should be prepended to or appended to
sys.path
in IPython console and Jedi completion environments.user_paths
,system_paths
, andprioritize
.user_paths
andsystem_paths
are dictionaries with path as key and enabled state as value.prioritize
is a boolean. The unofficial configuration keyspath
,user_path
, andsystem_path
are no longer used. Thespyder_pythonpath
configuration key remains unchanged.SPY_PYTHONPATH
environment variable is eliminated in favor of directly accessing thespyder_pythonpath
configuration key in thepythonpath_manager
configuration section on startup of IPython console kernels.sig_pythonpath_changed
now sends the newspyder_pythonpath
value (list of strings) andprioritize
(boolean). This signal no longer sends the "old" paths. The old paths were only required byspyder-kernels
in order to remove those paths fromsys.path
before adding the new paths tosys.path
. The update tospyder-kernels
in the companion PR eliminates the need for sending the "old" paths.Secondary Changes
In order to simplify the handling of PYTHONPATH, the following changes were made to the Pythonpath Manager plugin. These do not directly affect the UI, UX, or plugin API, but streamline and clarify the actions performed within the plugin.
PythonpathContainer
container object and thePathManager
widget object were changed frompath
,not_active_path
,user_path
,system_path
, andoriginal_path_dict
, to the less ambiguoususer_paths
andsystem_paths
. The latter are maintained asOrderedDict
objects throughout.pythonpath_manager
configurations are now only set inPythonpathContainer._save_paths
, and only on condition of change, rather than in multiple locations throughout the container andPathManager
widget.sig_pythonpath_changed
signal is emitted only inPythonpathContainer._save_paths
, and only on condition thatspyder_pythonpath
orprioritize
has changed.Companion PRs
extra_paths
to be placed in front ofsys.path
python-lsp/python-lsp-server#527.Outstanding questions
python-lsp-server.pylsp.Document.sys_path
be removed (API break)?new_dlg.kfp.text() == pytest.kfp
andnew_dlg.pw.text() == pytest.pw
fail on latest master? Why are they skipped for CI?Issue(s) Resolved
Fixes #17066
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct:
@mrclary