Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update service provider to use bindShared(). #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update service provider to use bindShared(). #21

wants to merge 2 commits into from

Commits on Sep 2, 2014

  1. Update service provider to use bindShared().

    @travisamiller
    travisamiller committed Sep 2, 2014
    Configuration menu
    Copy the full SHA
    b0d3443 View commit details
    Browse the repository at this point in the history

  2. Add checks on $credentials to prevent notices. 

    The default laravel configuration does not define all config options for
the sqlite connection:

https://github.com/laravel/laravel/blob/master/app/config/database.php

Add an `isset()` check on `$credentials` for the following index to avoid
PHP undefined index notices:

$credentials['username']
$credentials['password']
$credentials['host']
    @travisamiller
    travisamiller committed Sep 2, 2014
    Configuration menu
    Copy the full SHA
    8d79282 View commit details
    Browse the repository at this point in the history