Allow Rails 7.2 #5843
Draft
Allow Rails 7.2 #5843
+1,476
−1,483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog:solidus_core
There was a problem hiding this comment.
How should we handle the error we get with Ransack 4.2 and above? It doesn't look like there has been any movement on the PR to fix the issue.
That's a very good question. I need to read on the issue first in order to make an opinion. Since I use Ransack 4.2 with great success in several other apps and engines I am not sure why this is an issue in Solidus at all. |
|
I looked into the problem and I am sure I can replace the custom ransacker with normal ransack. PR upcoming maybe tomorrow |
We introduced a custom Ransacker to allow filtering producs by their variants option values in the new admin interface. This ransacker is broken in latest Ransack v4.2 and overly complicated. By introducing a option_values association to products, that does the same join over variants_including_master and their distinct option_values we can use normal ransack search. Quoting the Ransack documentation: > "Ransackers, like scopes, are not a cure-all. Many use cases can be better solved with a standard Ransack search on a dedicated database search field, which is faster, index-able, and scales better than converting/ransacking data on the fly."
Now that we removed the broken ransacker in previous commit, we can allow Ransack v4.2 - with Rails 7.2 support - again.
We do not use the custom ransacker this was necessary for
Should be fixed by #5853 |
We need at least v3.7 of awesome_nested_set for Rails 7.2 support
Rails 7.2 requires it and 3.0 is out of support anyway.
tvdeyen
force-pushed
the
rails-7.2
branch
2 times, most recently
from
329a769
to
6ac936c
Compare
Rails 7.2 removed migration_context from ActiveRecord::Base.connection
The file lives in tasks and the projects are in the root folder.
Without that ActiveRecord 7.2 expects a DB table for it.
Now, with Ruby 3.1 we need to address some code style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #5853
We need at least v3.7 of awesome_nested_set for Rails 7.2 support
Summary
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: