Grammatic error fix, Comments in code for easy understanding, more explanation on msg macro #417
Conversation
| types `AccountInfo` and `u8`, respectively. A “slice” is a view into a block of | ||
| memory representing a contiguous sequence of elements of a single type, but | ||
| without needing to own the entire data. It’s important because it allows | ||
| functions to handle inputs of varying lengths efficiently. |
There was a problem hiding this comment.
Good change. I think the old code was written by someone confused between vectors and slices. Probably me. 😅
There was a problem hiding this comment.
alright. thanks for the review.
| `use` commands at the top of a Rust file to make the code more readable and | ||
| maintainable. |
There was a problem hiding this comment.
Honestly I think the old version was better. It's clear from 'we can bring an item into scope so that it can be reused throughout a file without specifying the full path each time.' that the code is now more readable.
There was a problem hiding this comment.
Okay I would take this to the old version/way.
| account_info::AccountInfo, // Importing AccountInfo for account handling | ||
| entrypoint, // Importing entrypoint macro for defining program entry | ||
| entrypoint::ProgramResult, // Importing ProgramResult to handle function return type | ||
| pubkey::Pubkey, // Importing Pubkey to handle public keys | ||
| msg // Importing msg macro for logging messages |
There was a problem hiding this comment.
Can you make this less redundant? Just tell me what each of these are. You don't need to say their name.
account_info::AccountInfo, // A Solana account
entrypoint, // A macro to define the function that handles incoming instructions
okay I am on it. |
|
@mikemaccana thank you for making out some time to review this work. please if you have any more changes you would love me to implement, I would be glad to make the fix. I also messaged you on Telegram to find out if we can add more language support to "intro-to-solana". |
Reverted changes on arbitrary-cpi taking it back to normal.
|
Hello @mikemaccana and @nickfrosty Hope you're both doing great 👍. I have made the necessary adjustments and I also updated arbitrary-cpi.md to it's most recent form to avoid any conflicts. Pls 🙏 merge if it's ok. Thank you and best regards... |
Problem
The original lesson/code provided lacked clarity in certain areas, particularly in the explanation of paths and scope, function declarations, the concept of Solana programs, entry point syntax, and error handling. These issues might lead to confusion for readers, especially those new to Rust or Solana programming.
Summary of Changes
Paths and Scope Clarification:
usestatement, highlighting its importance in making code more readable and maintainable by bringing items into scope.Function Declaration Explanation:
Entry Point Code - Syntax and Comments:
msg! Macro and Error Handling:
msg!macro for logging and introduced basic concepts of error handling within Solana programs.