Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly modernized #97

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Slightly modernized #97

wants to merge 1 commit into from

Conversation

hathawsh
Copy link

@hathawsh hathawsh commented Nov 2, 2017

Changes:

  1. The websocket-client library no longer exports ConnectionClosedException. It now exports WebSocketConnectionClosedException. I updated the tests to match.

  2. I updated the expected content of the hidden iframe. There is now a _sockjs_onload variable.

  3. The raw websocket protocol is now allowed to close with an empty message.

Copy link

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please rebase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants