Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract redirect location handling and clarify behaviour. #172

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix commented Aug 13, 2024

Fixes #171.

Types of Changes

  • New feature.
  • Maintenance.

Contribution

@ioquatix ioquatix force-pushed the relative-location-absolute-uri branch from 7d170a4 to 7d4da97 Compare August 13, 2024 23:30
Copy link

@korbin korbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - this should allow for easy inheritance for an absolute redirect handler.

@ioquatix ioquatix force-pushed the relative-location-absolute-uri branch from 51c4c14 to 2b56c80 Compare August 14, 2024 01:34
@ioquatix
Copy link
Member Author

@korbin I'll probably rename this class. I'll leave a compatibility shim in for a while. The scope has expanded beyond it's original name.

@ioquatix ioquatix merged commit 11b9d5d into main Aug 14, 2024
32 of 40 checks passed
@ioquatix ioquatix deleted the relative-location-absolute-uri branch August 14, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async::HTTP::RelativeLocation doesn't seem to work for absolute URLs
2 participants