Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ecosystems support for docker, swift #38

Merged
merged 4 commits into from
Aug 18, 2023

Conversation

mcombuechen
Copy link
Collaborator

@mcombuechen mcombuechen commented Aug 11, 2023

This adds support for purl types docker and swift when enriching via ecosyste.ms.

It also fixes an issue with the package name mapping logic, where the maven logic was applied to most purl types.

It also resolves apk purls to repository alpine-edge, since alpine on its own is not complete.

image

@garethr
Copy link
Collaborator

garethr commented Aug 13, 2023

I've merged in the Go change from the other PR, and it's clashing with this. It looks like several discrete changes made in a single commit, so was harder to rebase out.

If you could resubmit, with separate logical changes in separate commits it would make it easier in general to integrate.

@mcombuechen
Copy link
Collaborator Author

@garethr yes this was a bit more than just a feature addition. I split all changes up into 4 commits, should be easier to review now. Let me know what you think.

@garethr garethr merged commit 0c804c2 into snyk:main Aug 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants