Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1672694: Move window + snow_partition_iterator to plugin folder #2329

Merged
merged 3 commits into from
Sep 20, 2024
Merged

SNOW-1672694: Move window + snow_partition_iterator to plugin folder #2329

merged 3 commits into from
Sep 20, 2024

Conversation

sfc-gh-joshi
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1672694

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

Moves yet more files out of snowflake/snowpark/modin/pandas into snowflake/snowpark/modin/plugin.

@sfc-gh-joshi sfc-gh-joshi requested a review from a team as a code owner September 19, 2024 20:29
@sfc-gh-joshi sfc-gh-joshi added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Sep 19, 2024
sfc-gh-helmeleegy
sfc-gh-helmeleegy approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sfc-gh-joshi sfc-gh-joshi merged commit 7622173 into main Sep 20, 2024
35 checks passed
@sfc-gh-joshi sfc-gh-joshi deleted the joshi-SNOW-1672694-move-window branch September 20, 2024 18:01
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-nkrishna sfc-gh-nkrishna sfc-gh-nkrishna approved these changes

@sfc-gh-helmeleegy sfc-gh-helmeleegy sfc-gh-helmeleegy approved these changes

@sfc-gh-jkew sfc-gh-jkew Awaiting requested review from sfc-gh-jkew sfc-gh-jkew is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay Awaiting requested review from sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md snowpark-pandas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-joshi @sfc-gh-nkrishna @sfc-gh-helmeleegy