[SIT-2372] Add the DataFrame.map method
#2315
Conversation
sfc-gh-lfallasavendano
requested review from
sfc-gh-yixie,
sfc-gh-yuwang and
sfc-gh-jrose
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
@sfc-gh-aalam could you help review this PR? |
src/snowflake/snowpark/dataframe.py
Outdated
| self, | ||
| func: Callable, | ||
| output_types: list[StructType], | ||
| output_column_names: Optional[list[str]] = None, |
There was a problem hiding this comment.
I suggest adding a * before this parameter to make these optional parameters key-word arguments.
There was a problem hiding this comment.
Thanks for your suggestion.
I just removed the extra_packages parameter and added a **kwargs parameter to pass arguments to the UTDF registration (as with other similar methods).
| @@ -4188,6 +4189,117 @@ def _explain_string(self) -> str: | |||
|
|
|||
| return f"{msg}\n--------------------------------------------" | |||
|
|
|||
| def map( | |||
There was a problem hiding this comment.
A UDTF call may have other parameters like partitioning.
There was a problem hiding this comment.
As part of the previous comment, the**kwargs parameter can be used to pass arguments to the UDTF registration.
Adds the `DataFrame.map` method which applies a Python function to every element of a DataFrame.
Added a `kwargs` parameter to pass arguments to the UDTF registration function. Part of the code review comments.
sfc-gh-lfallasavendano
force-pushed
the
lfallasavendano-SIT-2372-dataframe-map
branch
from
55fd1bb
to
4fb368f
Compare
Skips executing `test_map` in local testing mode because it requires UDTFs.
|
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
|
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
|
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
Adds the
DataFrame.mapmethod which applies a Python function to every element of a DataFrame.Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SIT-2372
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Adds the
DataFrame.mapmethod that applies a Python function to every row of a DataFrame.