Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1418523: concurrent file operations #2288

Open
wants to merge 2 commits into
base: aalam-SNOW-1418523-make-analyzer-server_connection-thread-safe
Choose a base branch
from
Open

SNOW-1418523: concurrent file operations #2288

wants to merge 2 commits into from

Conversation

sfc-gh-aalam
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1418523

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

    This change adds tests for ensuring fileIO works correctly in multithreading mode. Since file io relies on cursor, make cursor safe in SNOW-1418523 make analyzer server connection thread safe #2282 is sufficient to achieve this goal.

@sfc-gh-aalam sfc-gh-aalam requested a review from a team as a code owner September 12, 2024 22:09
@sfc-gh-aalam sfc-gh-aalam requested review from sfc-gh-yixie, sfc-gh-aling and sfc-gh-jrose and removed request for a team September 12, 2024 22:09
@github-actions GitHub Actions
Copy link

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

@sfc-gh-aalam sfc-gh-aalam mentioned this pull request Sep 17, 2024
Draft
7 tasks
@sfc-gh-aalam sfc-gh-aalam requested a review from a team as a code owner September 17, 2024 21:45
@sfc-gh-aalam sfc-gh-aalam requested review from sfc-gh-jkew and sfc-gh-lmukhopadhyay and removed request for a team September 17, 2024 21:45
@github-actions GitHub Actions
Copy link

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

@sfc-gh-aalam sfc-gh-aalam force-pushed the aalam-SNOW-1418523-concurrent-file-operations branch from fde612e to df3263c Compare September 17, 2024 21:52
@github-actions GitHub Actions
Copy link

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

@github-actions GitHub Actions
Copy link

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-aling sfc-gh-aling sfc-gh-aling approved these changes

@sfc-gh-yuwang sfc-gh-yuwang sfc-gh-yuwang approved these changes

@sfc-gh-yixie sfc-gh-yixie Awaiting requested review from sfc-gh-yixie sfc-gh-yixie is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-jrose sfc-gh-jrose Awaiting requested review from sfc-gh-jrose sfc-gh-jrose is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-jkew sfc-gh-jkew Awaiting requested review from sfc-gh-jkew sfc-gh-jkew was automatically assigned from snowflakedb/snowpark-pandas-api

@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay Awaiting requested review from sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay was automatically assigned from snowflakedb/snowpark-pandas-api

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-aalam @sfc-gh-aling @sfc-gh-yuwang