SNOW-1651234: Fix create_dataframe throwing an exception for structured dtypes #2240
+51
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
sfc-gh-jrose
changed the title
sfc-gh-aalam
reviewed
Sep 5, 2024
| pytest.skip("Test requires iceberg support and structured type support.") | ||
|
|
||
| _, __, expected_schema = STRUCTURED_TYPES_EXAMPLES[True] | ||
| table_name = f"snowpark_structured_dtypes_{uuid.uuid4().hex[:5]}" |
There was a problem hiding this comment.
just curious, any reason why we are using this naming format instead os standard function Utils.random_table_name()?
There was a problem hiding this comment.
No particular reason. Other tests in this file did it this way so I was mostly just copying style.
sfc-gh-aalam
approved these changes
Sep 5, 2024
|
Defering this change until structured type support is rolled out completely. |
|
We can continue to merge this PR since it doesn't hurt anything. |
CHANGELOG.md
Outdated
| @@ -49,6 +49,7 @@ | |||
| - Fixed a bug where calling `DataFrame.to_snowpark_pandas_dataframe` without explicitly initializing the Snowpark pandas plugin caused an error. | |||
| - Fixed a bug where using the `explode` function in dynamic table creation caused a SQL compilation error due to improper boolean type casting on the `outer` parameter. | |||
| - Fixed a bug where using `to_pandas_batches` with async jobs caused an error due to improper handling of waiting for asynchronous query completion. | |||
| - Fixed a bug in `session.create_dataframe` that caused a sql error when creating an iceberg table with structured datatypes. | |||
There was a problem hiding this comment.
Better remove this one because there are other problems with create_dataframe.
sfc-gh-jrose
added
the
NO-CHANGELOG-UPDATES
sfc-gh-yixie
approved these changes
Sep 20, 2024
sfc-gh-jrose
deleted the
jrose_snow_1651234_structured_create_dataframe
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1651234
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This change modifies the logic for
session.create_dataframeto add support for StructType object as well as removes it's dependency onto_objectandto_array. Those calls create semi-structured columns which are incompatible with iceberg. By switching to a cast full type information is retained instead.