Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1373887: [Local Testing] enable diamond shaped joins #2215

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sfc-gh-jrose
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1373887

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
  3. Please describe how your code solves the related issue.

    This bug had two component issues:

  • Join plans dropped column aliases when joined columns shared uuids. In theory columns with the same uuid are the same column so it should be ok to just favor one side or the other of the join when these conflicts occur. I've chosen the left side, but I think it's arbitrary.
  • When trying to flatten a select query the would check if the pre-flatten dataframe could support a new column lookup rather than the post-flatten dataframe. I've changed it to look at the new post-flatten so that flattening is disabled when this would lose information.

@sfc-gh-jrose sfc-gh-jrose requested review from sfc-gh-aling and a team September 3, 2024 21:27
@github-actions github-actions bot added the local testing Local Testing issues/PRs label Sep 3, 2024
@sfc-gh-jrose sfc-gh-jrose marked this pull request as ready for review September 4, 2024 21:41
@sfc-gh-jrose sfc-gh-jrose requested a review from a team as a code owner September 4, 2024 21:41
@sfc-gh-aalam sfc-gh-aalam self-requested a review September 4, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
local testing Local Testing issues/PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants