Skip to content

Commit

Permalink
TEST: Add xfail for test_df_groupby_idxmax_idxmin_on_axis_0 (#2335)
Browse files Browse the repository at this point in the history
This PR adds an xfail to `test_df_groupby_idxmax_idxmin_on_axis_0` since
`idxmax/idxmin` results in a non-deterministic ordering when tiebreaking
values.

Signed-off-by: Naren Krishna <[email protected]>
Co-authored-by: Jialin Jiao <[email protected]>
  • Loading branch information
sfc-gh-nkrishna and sfc-gh-jjiao committed Sep 20, 2024
1 parent 5514105 commit 1d8746a
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion tests/integ/modin/groupby/test_groupby_idxmax_idxmin.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,18 @@
from tests.utils import running_on_public_ci


@pytest.mark.parametrize("grouping_columns", ["B", ["A", "B"]])
@pytest.mark.parametrize(
"grouping_columns",
[
pytest.param(
"B",
marks=pytest.mark.xfail(
reason="SNOW-1270521: `idxmax/idxmin` results in a non-deterministic ordering when tiebreaking values"
),
),
["A", "B"],
],
)
@pytest.mark.parametrize("skipna", [False, True])
@pytest.mark.parametrize("func", ["idxmax", "idxmin"])
@sql_count_checker(query_count=1)
Expand Down

0 comments on commit 1d8746a

Please sign in to comment.