SNOW-1657037: Remove secrets from debug logs. #2058
+17
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jrose
added
DO_NOT_PORT_CHANGES_TO_SP
sfc-gh-jrose
force-pushed
the
jrose_snow_1657037_filter_secrets
branch
from
22bfa6c
to
8b61823
Compare
sfc-gh-aalam
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1657037 SNOW-1642759
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This change removes a log line that would leak secrets as well as changes another from a blacklist approach to a whitelist approach.
(Optional) PR for stored-proc connector:
Stored proc does not share the auth submodule.