Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1612981 loglevel for errors Debug -> Error #1008

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

sfc-gh-dszmolka
Copy link
Contributor

Description

Debugging #1004 made apparent that it would be more helpful if the errors encountered during communicating with Snowflake would not be 'hidden' under Debug loglevel, as enabling Debug loglevel for the whole driver causes a lot of logs.

Exposing unsuccessful requests at Error loglevel could help see and catch them easier even without needing to enable Debug logs across all the driver.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.61%. Comparing base (7e67f65) to head (44b3c9c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1008      +/-   ##
==========================================
+ Coverage   85.56%   85.61%   +0.04%     
==========================================
  Files         106      106              
  Lines       10788    10788              
  Branches     1033     1033              
==========================================
+ Hits         9231     9236       +5     
+ Misses       1310     1304       -6     
- Partials      247      248       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-dszmolka sfc-gh-dszmolka merged commit adac81a into master Aug 27, 2024
55 checks passed
@sfc-gh-dszmolka sfc-gh-dszmolka deleted the SNOW-1612981-log-errors-at-error-level branch August 27, 2024 15:11
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants