Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1643309 Move version create to app package entity #1585

Merged
merged 2 commits into from
Sep 20, 2024
Merged

SNOW-1643309 Move version create to app package entity #1585

merged 2 commits into from
Sep 20, 2024

Conversation

sfc-gh-fcampbell
Copy link
Collaborator

@sfc-gh-fcampbell sfc-gh-fcampbell commented Sep 17, 2024 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Moves implementation of snow app version create to ApplicationPackageEntity.version_drop and wires it into snow ws version create too.

@sfc-gh-fcampbell sfc-gh-fcampbell changed the title SNOW-1643309 Move stuff to app package entity SNOW-1643309 Move version create to app package entity Sep 17, 2024
@sfc-gh-fcampbell sfc-gh-fcampbell force-pushed the frank-ws-version-create branch 5 times, most recently from 70a5b59 to a5eccc4 Compare September 20, 2024 14:49
sfc-gh-fcampbell
sfc-gh-fcampbell commented Sep 20, 2024
View reviewed changes
src/snowflake/cli/_plugins/nativeapp/application_entity.py
@@ -656,40 +649,3 @@ def get_existing_app_info(
return sql_executor.show_specific_object(
"applications", app_name, name_col=NAME_COL
)

@staticmethod
def get_existing_version_info(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to ApplicationPackageEntity

@sfc-gh-fcampbell sfc-gh-fcampbell marked this pull request as ready for review September 20, 2024 16:16
@sfc-gh-fcampbell sfc-gh-fcampbell enabled auto-merge (squash) September 20, 2024 20:35
@sfc-gh-fcampbell sfc-gh-fcampbell merged commit 7091776 into main Sep 20, 2024
37 checks passed
@sfc-gh-fcampbell sfc-gh-fcampbell deleted the frank-ws-version-create branch September 20, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-bdufour sfc-gh-bdufour sfc-gh-bdufour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-fcampbell @sfc-gh-bdufour