Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added an official dependency on rJava and 2 explicit references to it… #13

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
^.*\.Rproj$
^\.Rproj\.user$
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,6 @@
vignettes/*.html
vignettes/*.pdf
.Rproj.user

# pkgdown documentation
docs
3 changes: 2 additions & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ Imports:
magrittr,
lazyeval (>= 0.1.10),
dbplyr,
dplyr (>= 0.5.0)
dplyr (>= 0.5.0),
rJava
Suggests:
Lahman (>= 3.0-1),
nycflights13,
Expand Down
4 changes: 2 additions & 2 deletions R/src-snowflakedb.R
Original file line number Diff line number Diff line change
Expand Up @@ -186,8 +186,8 @@ src_snowflakedb <- function(user = NULL,
)

# initalize the JVM and set the snowflake properties
.jinit()
.jcall(
rJava::.jinit()
rJava::.jcall(
"java/lang/System",
"S",
"setProperty",
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ The `dplyr.snowflakedb` connectivity to SnowflakeDB uses the `RJDBC` package, ho

If you are using R on Mac OS X, please see [this wiki page](https://github.com/snowflakedb/dplyr-snowflakedb/wiki/Configuring-R-rJava-RJDBC-on-Mac-OS-X) for the necessary installation steps for `rJava`.

Once you have `rJava` installed and verified it is using Java 8, you can install `dplyr` and dependancies.
Once you have `rJava` installed and verified it is using Java 8, you can install `dplyr` and dependencies.

```R
install.packages(c("RJDBC", "DBI", "dplyr"))
Expand Down