Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for psr/http-message ^2.0 #3302

Conversation

rotexdegba
Copy link

@rotexdegba rotexdegba commented Dec 12, 2023

Changed psr/http-message requirement to ^1.1 || ^2.0 in composer.json.

Note that in dev environment (ie. cloning this repo with this pull request merged and running the tests in PHP 7.4) psr/http-message ^1.1 always gets pulled in by composer for PHP 7.4 users because PSR 7 implementations like laminas/laminas-diactoros ^2.17 in the require-dev section of https://github.com/slimphp/Slim/blob/4.x/composer.json requires psr/http-message ^1.0.

For users requiring slim/slim in their applications and using a PSR 7 implementation like nyholm/psr7 ^1.8 which requires psr/http-message ^1.1 || ^2.0 ( https://github.com/Nyholm/psr7/blob/1.8.1/composer.json ), psr/http-message ^2.0 will be pulled in for those applications.

Closes #3296

@l0gicgate l0gicgate added this to the 4.13.0 milestone Dec 14, 2023
@coveralls
Copy link

Coverage Status

coverage: 99.427%. remained the same
when pulling 187172d on rotexdegba:github-issue-3296-psr-http-message-version-requirement-bump-up
into 56ead41 on slimphp:4.x.

@l0gicgate l0gicgate changed the title GitHub issue 3296 psr http message version requirement bump up Add support for psr/http-message ^2.0 Dec 14, 2023
@l0gicgate l0gicgate merged commit 917c9df into slimphp:4.x Dec 14, 2023
6 checks passed
@kosciuk
Copy link

kosciuk commented Mar 10, 2024

composer require slim/psr7

Problem 1
- slim/psr7[0.1.0, ..., 0.6] require php ^7.1 -> your php version (8.3.0) does not satisfy that requirement.
- slim/psr7[1.0.0, ..., 1.2.0] require php ^7.2 -> your php version (8.3.0) does not satisfy that requirement.
- slim/psr7[1.3.0, ..., 1.6.1] require psr/http-message ^1.0 -> found psr/http-message[1.0, 1.0.1, 1.1] but the package is fixed to 2.0 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.
- Root composer.json requires slim/psr7 * -> satisfiable by slim/psr7[0.1.0, ..., 0.6, 1.0.0, ..., 1.6.1].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PSR 7 http-message version requirement
4 participants