Merge branch 'JoeBengalen-fix-basepath-space' into 3.x

Closes #1946
slimphp · Mar 18, 2017 · c2d7ae4 · c2d7ae4
2 parents 7aabd47 + df1591c
commit c2d7ae4
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/Slim/Http/Uri.php b/Slim/Http/Uri.php
@@ -203,6 +203,7 @@ public static function createFromEnvironment(Environment $env)
         // parse_url() requires a full URL. As we don't extract the domain name or scheme,
         // we use a stand-in.
         $requestUri = parse_url('http://example.com' . $env->get('REQUEST_URI'), PHP_URL_PATH);
+        $requestUri = rawurldecode($requestUri);
 
         $basePath = '';
         $virtualPath = $requestUri;

diff --git a/tests/Http/UriTest.php b/tests/Http/UriTest.php
@@ -562,6 +562,20 @@ public function testCreateEnvironmentWithBasePath()
         $this->assertEquals('http://localhost/foo/bar', (string) $uri);
     }
 
+    public function testCreateEnvironmentWithBasePathContainingSpace()
+    {
+        $environment = Environment::mock([
+            'SCRIPT_NAME' => "/f'oo bar/index.php",
+            'REQUEST_URI' => "/f'oo%20bar/baz",
+        ]);
+        $uri = Uri::createFromEnvironment($environment);
+
+        $this->assertEquals("/f%27oo%20bar", $uri->getBasePath());
+        $this->assertEquals('baz', $uri->getPath());
+
+        $this->assertEquals('http://localhost/f%27oo%20bar/baz', (string) $uri);
+    }
+
     public function testGetBaseUrl()
     {
         $environment = Environment::mock([