Merge pull request #803 from fredemmott/v2.4.2-derace-testExpiresAsSt…

…ring Fix race condition in testExpiresAsString
slimphp · Apr 4, 2014 · b2d05e0 · b2d05e0
2 parents 0505f97 + b86f117
commit b2d05e0
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/tests/SlimTest.php b/tests/SlimTest.php
@@ -805,15 +805,19 @@ public function testExpiresAsString()
             'SCRIPT_NAME' => '/foo', //<-- Physical
             'PATH_INFO' => '/bar', //<-- Virtual
         ));
-        $expectedDate = gmdate('D, d M Y H:i:s T', strtotime('5 days'));
         $s = new \Slim\Slim();
         $s->get('/bar', function () use ($s) {
             $s->expires('5 days');
         });
         $s->call();
         list($status, $header, $body) = $s->response()->finalize();
         $this->assertTrue(isset($header['Expires']));
-        $this->assertEquals($header['Expires'], $expectedDate);
+
+        $this->assertEquals(
+          strtotime('5 days'),
+          strtotime($header['Expires']),
+          1 // delta
+        );
     }
 
     /**