Ensure that withMethod() does what is expected

If I call withMethod(), then I expect that what I've set to be what is set! i.e. we should not check for the magic _METHOD or the X-Http-Method-Override header if withMethod() has been called.
slimphp · Dec 6, 2015 · 45e7f5b · 45e7f5b
1 parent b247f36
commit 45e7f5b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Slim/Http/Request.php b/Slim/Http/Request.php
@@ -286,7 +286,7 @@ public function withMethod($method)
         $method = $this->filterMethod($method);
         $clone = clone $this;
         $clone->originalMethod = $method;
-        $clone->method = null; // <-- Force method override recalculation
+        $clone->method = $method;
 
         return $clone;
     }

diff --git a/tests/Http/RequestTest.php b/tests/Http/RequestTest.php
@@ -70,7 +70,7 @@ public function testWithMethod()
     {
         $request = $this->requestFactory()->withMethod('PUT');
 
-        $this->assertAttributeEquals(null, 'method', $request);
+        $this->assertAttributeEquals('PUT', 'method', $request);
         $this->assertAttributeEquals('PUT', 'originalMethod', $request);
     }