Address PR comments

slimphp · Apr 4, 2020 · 040a831 · 040a831
1 parent 7053c6d
commit 040a831
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 11 deletions.
diff --git a/Slim/Logger.php b/Slim/Logger.php
@@ -1,5 +1,13 @@
 <?php
 
+/**
+ * Slim Framework (https://slimframework.com)
+ *
+ * @license https://github.com/slimphp/Slim/blob/4.x/LICENSE.md (MIT License)
+ */
+
+declare(strict_types=1);
+
 namespace Slim;
 
 use Psr\Log\AbstractLogger;

diff --git a/tests/AppTest.php b/tests/AppTest.php
@@ -726,7 +726,7 @@ public function testAddErrorMiddleware()
         $responseFactory = $this->prophesize(ResponseFactoryInterface::class)->reveal();
 
         /** @var LoggerInterface $logger */
-        $logger = $this->createMock(LoggerInterface::class);
+        $logger = $this->prophesize(LoggerInterface::class)->reveal();
 
         // Create the app.
         $app = new App($responseFactory);

diff --git a/tests/Handlers/ErrorHandlerTest.php b/tests/Handlers/ErrorHandlerTest.php
@@ -29,6 +29,11 @@
 
 class ErrorHandlerTest extends TestCase
 {
+    private function getMockLogger(): LoggerInterface
+    {
+        return $this->createMock(LoggerInterface::class);
+    }
+
     public function testDetermineRenderer()
     {
         $handler = $this
@@ -392,9 +397,4 @@ public function testLogErrorRenderer()
         $writeToErrorLogMethod->setAccessible(true);
         $writeToErrorLogMethod->invoke($handler);
     }
-
-    private function getMockLogger(): LoggerInterface
-    {
-        return $this->createMock(LoggerInterface::class);
-    }
 }
diff --git a/tests/Middleware/ErrorMiddlewareTest.php b/tests/Middleware/ErrorMiddlewareTest.php
@@ -27,6 +27,11 @@
 
 class ErrorMiddlewareTest extends TestCase
 {
+    private function getMockLogger(): LoggerInterface
+    {
+        return $this->createMock(LoggerInterface::class);
+    }
+
     public function testSetErrorHandler()
     {
         $responseFactory = $this->getResponseFactory();
@@ -284,9 +289,4 @@ public function testErrorHandlerHandlesThrowables()
 
         $this->expectOutputString('Oops..');
     }
-
-    private function getMockLogger(): LoggerInterface
-    {
-        return $this->createMock(LoggerInterface::class);
-    }
 }