Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on ralouphie/getallheaders #273

Closed
wants to merge 1 commit into from
Closed

Remove dependency on ralouphie/getallheaders #273

wants to merge 1 commit into from

Conversation

williamdes
Copy link
Contributor

This was added in #76
Then moved as a normal dependency in #111 for #101

And got upgraded in #112

I see no reason this function would be now missing in PHP 7.4+

This was added in #76
Then moved as a normal dependency in #111 for #101
And got upgraded in #112
@l0gicgate l0gicgate added this to the 1.7.0 milestone Dec 7, 2022
@williamdes williamdes marked this pull request as draft December 13, 2022 20:12
@williamdes
Copy link
Contributor Author

I am starting to ask myself why it is absent or not on some systems
I think this should not be merged for now. The error that is seen here is also seen on my Debian packaging where I do not have the polyfill. See: https://github.com/slimphp/Slim-Psr7/actions/runs/3609229456/jobs/6145955522#step:7:54

@ralouphie is your lib still open for maintenance ?

@williamdes
Copy link
Contributor Author

I am closing this, but the library should get some maintenance. Depending on an old non maintained library is not very great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants