Merge pull request #86 from l0gicgate/AddStreamGetMetadataTest

Add test coverage for Stream::getMetadata
slimphp · May 3, 2019 · 8ce2c78 · 8ce2c78
2 parents 6fb2748 + 30956c3
commit 8ce2c78
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/Stream.php b/src/Stream.php
@@ -83,7 +83,7 @@ public function __construct($stream)
     public function getMetadata($key = null)
     {
         if (!$this->stream) {
-            return $this->meta;
+            return null;
         }
 
         $this->meta = stream_get_meta_data($this->stream);

diff --git a/tests/StreamTest.php b/tests/StreamTest.php
@@ -155,6 +155,15 @@ public function testAttachAgain()
         $attachMethod->invoke($stream, $this->pipeFh);
     }
 
+    public function testGetMetaDataReturnsNullIfStreamIsDetached()
+    {
+        $resource = fopen('php://temp', 'rw+');
+        $stream = new Stream($resource);
+        $stream->detach();
+
+        $this->assertNull($stream->getMetadata());
+    }
+
     private function openPipeStream()
     {
         $this->pipeFh = popen('echo 12', 'r');