Merge pull request #309 from akrabat/php83

Ensure that we work with PHP 8.3
slimphp · Jun 8, 2024 · 372e11c · 372e11c
2 parents f583b1c + d7b6767
commit 372e11c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -10,7 +10,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php: [8.0, 8.1, 8.2]
+        php: [8.0, 8.1, 8.2, 8.3]
         experimental: [false]
         include:
           - php: 8.2

diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -1,5 +1,6 @@
 parameters:
   level: max
-  checkMissingIterableValueType: false
+  ignoreErrors:
+    - identifier: missingType.iterableValue
   paths:
     - src
diff --git a/src/Stream.php b/src/Stream.php
@@ -304,7 +304,7 @@ public function read($length): string
     {
         $data = false;
 
-        if ($this->isReadable() && $this->stream && $length >= 0) {
+        if ($this->isReadable() && $this->stream && $length > 0) {
             $data = fread($this->stream, $length);
         }