Merge pull request #151 from adriansuter/patch-response-headers

Fix Authorization Headers
slimphp · Feb 9, 2020 · 316ff1c · 316ff1c
2 parents 1f8bb50 + 3ae1689
commit 316ff1c
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/src/Response.php b/src/Response.php
@@ -124,7 +124,7 @@ public function __construct(
         ?StreamInterface $body = null
     ) {
         $this->status = $this->filterStatus($status);
-        $this->headers = $headers ? $headers : new Headers();
+        $this->headers = $headers ? $headers : new Headers([], []);
         $this->body = $body ? $body : (new StreamFactory())->createStream();
     }
 

diff --git a/tests/ResponseTest.php b/tests/ResponseTest.php
@@ -13,6 +13,7 @@
 use InvalidArgumentException;
 use PHPUnit\Framework\TestCase;
 use ReflectionProperty;
+use Slim\Psr7\Environment;
 use Slim\Psr7\Headers;
 use Slim\Psr7\Response;
 use Slim\Psr7\Stream;
@@ -146,7 +147,7 @@ public function testEmptyReasonPhraseForUnrecognisedCode()
     {
         $response = new Response();
         $response = $response->withStatus(199);
-        
+
         $this->assertSame('', $response->getReasonPhrase());
     }
 
@@ -165,4 +166,16 @@ public function testGetCustomReasonPhrase()
 
         $this->assertEquals('Custom Phrase', $clone->getReasonPhrase());
     }
+
+    public function testResponseHeadersDoNotContainAuthorizationHeader()
+    {
+        $_SERVER = Environment::mock(
+            [
+                'PHP_AUTH_USER' => 'foo'
+            ]
+        );
+
+        $response = new Response();
+        $this->assertEmpty($response->getHeaders());
+    }
 }