Merge pull request #120 from mapogolions/enhancement/unnecessary-guard

Removed unnecessary validation
slimphp · Aug 8, 2019 · 0b3be28 · 0b3be28
2 parents 3b8dc24 + f602cd1
commit 0b3be28
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 2 deletions.
diff --git a/src/Message.php b/src/Message.php
@@ -154,8 +154,6 @@ public function withAddedHeader($name, $value)
      */
     public function withoutHeader($name)
     {
-        Headers::validateHeaderName($name);
-
         $clone = clone $this;
         $clone->headers->removeHeader($name);
 

diff --git a/tests/HeadersTest.php b/tests/HeadersTest.php
@@ -75,6 +75,15 @@ public function testRemoveHeader()
         $this->assertEquals([], $headers->getHeaders());
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
+    public function testRemoveHeaderByIncompatibleStringWithRFC()
+    {
+        $headers = new Headers();
+        $headers->removeHeader('<incompatible with RFC>');
+    }
+
     public function testGetHeader()
     {
         $headers = new Headers([

diff --git a/tests/MessageTest.php b/tests/MessageTest.php
@@ -141,6 +141,17 @@ public function testWithoutHeader()
         $this->assertEquals($shouldBe, $clone->getHeaders());
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
+    public function testWithoutHeaderByIncompatibleStringWithRFC()
+    {
+        $headers = new Headers();
+        $response = new MessageStub();
+        $response->headers = $headers;
+        $response->withoutHeader('<incompatible with RFC');
+    }
+
     public function testGetBody()
     {
         $body = $this->getBody();