Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thin wall improvements (v3) #4790

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

Thin wall improvements (v3) #4790

wants to merge 36 commits into from

Commits on Sep 6, 2018

  1. Thin wall improvements

     - now keep the bit with 0 width to merge them instead of just delete them
     - merging algorithm re-coded (extensively)
     - change behavior of thick polyline to only 1 width value per point instead of 2 per pair of adjacent points.
     - do not post-process the voronoi diagram in polylines, now it's don in expolygon.medial_axis.
     - failsafes in perimeter_generator (too many splits, too small)
     - some new tests.
    supermerill committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    6ba61fe View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2018

  1. thin wall : medial axis:

    * corrections from review
    * more functions for a clearer code
    * now simplify the frontier with the anchor to avoid weird edge-cases.
    * new post-process: remove "curve edge" before merging
    * new post-process: cube corner: the small bit that go from the voronoi corner to the cube corner is now a "pulling string" that pull the voronoi corner a bit to make a nicer cube.
    * _variable_width : reduce the threshold for creating a new extrusion by half vs threshold to create segments (if not, it doesn't create enough)
    supermerill committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    2841809 View commit details
    Browse the repository at this point in the history
  2. forgot medial_axis.hpp/cpp files

    supermerill committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    e4484c4 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2018

  1. Merge remote-tracking branch 'remotes/origin/master' into alexrj_thin…

    …wall
    supermerill committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    418c770 View commit details
    Browse the repository at this point in the history
  2. correct error with Polygon / ExPolygon

    add to cmakelist
    add needed function (mostly copy from slic3rPE)
    supermerill committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    2235c87 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    97c226a View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2018

  1. some modifs for a small bug (a hole that appeared between thin zone a…

    …nd perimeter)
    supermerill committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    1c1451c View commit details
    Browse the repository at this point in the history
  2. change the all 'medial axis segments of a semicircumference have the …

    …same orientation'
    
    to 'all medial axis segments of a semicircumference have the same orientation (but the 2 end points)'
    supermerill committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    155a68b View commit details
    Browse the repository at this point in the history
  3. rename variable "near" as appveyor seems to not like it.

    correct a bug with offset parameters.
    supermerill committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    b6edcc4 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2018

  1. one more test, reworked the thin semi-circle test.

    some bugfix on the algo of thin_walls.
    supermerill committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    d0f5bd7 View commit details
    Browse the repository at this point in the history
  2. bugfix polylines & try to avoid many periemter splits.

    supermerill committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    32e9d9d View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2018

  1. debug test, relax min area for medial_axis

    supermerill committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    90df3a5 View commit details
    Browse the repository at this point in the history
  2. edge-case bugfix (a perimeter inside a thin_wall area)

    supermerill committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    ca9f3f7 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2018

  1. stop_at_min_width : do not extends the thin wall if it's over the min…

    …_width (can be toggled when calling expolygon.medial_axis).
    supermerill committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    6643d78 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2018

  1. bugfix, remove \t, #4640

    supermerill committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    137c99c View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2018

  1. Review corrections

    supermerill committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    4534c5e View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2018

  1. Medial axis: avoid duplication + bugfix

    supermerill committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    767fc86 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2018

  1. bugfix ensure_not_overextrude

    supermerill committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    44e7ec8 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2019

  1. Configuration menu
    Copy the full SHA
    fff41c2 View commit details
    Browse the repository at this point in the history
  2. taper ends of thin walls lines

    supermerill committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    69aea31 View commit details
    Browse the repository at this point in the history
  3. Merge remote-tracking branch 'remotes/origin/master' into alexrj_thin…

    …wall
    supermerill committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    8555930 View commit details
    Browse the repository at this point in the history
  4. typo

    supermerill committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    e34e75a View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2019

  1. Thin_wall / medial axis:

     - reworked thin_variable_width (discretize into segments of constant width)
     - bugfix taper_ends
     - add setting thin_walls_overlap to control the perimeter/thin wall overlap
     - add point.interpolate(%,point) : point method
    supermerill committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    fc46316 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2019

  1. bugfix thin wall / gapfill width

    supermerill authored and supermerill committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    f6ae12f View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2019

  1. medial axis: debug

     * concatenate_polylines_with_crossing: now connected the good end with the other good end
     * discretize_variable_width: now use TP.width->flow.spacing for gap-fill and TP.width->flow.width if possible for thin-walls.
     * bugfix thin wall (medial axis): use correct temp variables for main_fusion.
    supermerill committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    f06491c View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2019

  1. Configuration menu
    Copy the full SHA
    1687c5c View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2019

  1. Add sanity check for gapfill's min width.

    supermerill committed Apr 7, 2019
    Configuration menu
    Copy the full SHA
    1c45045 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2019

  1. Merge remote-tracking branch 'remotes/origin/master' into alexrj_thin…

    …wall
    supermerill committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    8e652f1 View commit details
    Browse the repository at this point in the history
  2. medial axis: fixes

     - taper_ends fix
     - empty_vector.back() bugfix
     - more accurate min width from nozzle diameter & layer height
     - add epsilon offset when trying to see if points are inside a polygon
     - failsafe not safe (do not fusion with a too high width).
     - add remove_collinear_points() in the simplify function.
    supermerill committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    d1a5fe2 View commit details
    Browse the repository at this point in the history
  3. Cleaning pull request

    adding comments
    supermerill committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    45a5630 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2019

  1. bugfix to test_fill

    supermerill committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    6273f0d View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2019

  1. Merge remote-tracking branch 'remotes/origin/master' into merill_thin…

    …wall
    supermerill committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    7770f70 View commit details
    Browse the repository at this point in the history
  2. some bugfix for medial axis

    add cp medial axis tests
    supermerill committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    d7357cc View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2020

  1. fix for edge-cases

    supermerill committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    79db85d View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2020

  1. Configuration menu
    Copy the full SHA
    a10cf71 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    da90a83 View commit details
    Browse the repository at this point in the history