Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stock Trading #2736

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Add Stock Trading #2736

merged 3 commits into from
Feb 14, 2024

Conversation

shi-rudo
Copy link
Contributor

@shi-rudo shi-rudo commented Aug 2, 2023

https://github.com/shi-rudo/awesome-stock-trading

List about valuable tools and educational resources about stock trading.

Commented pull requests:
#2391
#2734
#2692

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

Requirements for your pull request

  • ✅ Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it.
  • Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
  • You have to review at least 2 other open pull requests.
  • ✅ You have read and understood the instructions for creating a list.
  • ✅ This pull request has a title in the format Add Name of List. It should not contain the word Awesome.
  • ✅ Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.
  • ✅ Your entry should be added at the bottom of the appropriate category.
  • ✅ The title of your entry should be title-cased and the URL to your list should end in #readme.
  • ✅ No blockchain-related lists.
  • ✅ The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

  • Has been around for at least 30 days.
    That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
  • ✅ Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
  • ✅ The default branch should be named main, not master.
  • ✅ **Includes a succinct description of the project/theme at the top of the readme.
  • ✅ It's the result of hard work and the best I could possibly produce.
  • ✅ The repo name of your list should be in lowercase slug format: awesome-name-of-list.
  • ✅ The heading title of your list should be in title case format: # Awesome Name of List.
  • ✅ Non-generated Markdown file in a GitHub repo.
  • ✅ The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
  • ✅ Not a duplicate. Please search for existing submissions.
  • ✅ Only has awesome items. Awesome lists are curations of the best, not everything.
  • ✅ Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file.
  • ✅ Includes a project logo/illustration whenever possible.
  • ✅ Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
  • ✅ Includes the Awesome badge.
  • ✅ Has a Table of Contents section.
  • ✅ Has an appropriate license.
  • ✅ Has contribution guidelines.
  • ✅ All non-important but necessary content (like extra copyright notices, hyperlinks to sources, pointers to expansive content, etc) should be grouped in a Footnotes section at the bottom of the readme. The section should not be present in the Table of Contents.
  • ✅ Has consistent formatting and proper spelling/grammar.
  • ✅ Does not use hard-wrapping.
  • ✅ Does not include a CI (e.g. GitHub Actions) badge.
    You can still use a CI for linting, but the badge has no value in the readme.
  • ✅ Does not include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

@shi-rudo
Copy link
Contributor Author

shi-rudo commented Aug 2, 2023

unicorn

@hyperupcall
Copy link
Contributor

Awesome Stock Trading looks pretty good so far - I think there can be a few areas of improvement:

  • Under the books section, the descriptions for each book is kind of long. I think it would be easier to follow (and scroll) if each description was made more succinct (not autogenerating the description with AI).
  • The repository description is kind of long, shorting it would make it more clear at a glance
  • In general, not using AI to autogenerate descriptions, and writing them on your own to be more succinct, clear, and less obtuse
  • It might be a good idea to link youtube channels with videos about stock market trading, kinds of trades one can make, strategies, etc.

@hyperupcall hyperupcall mentioned this pull request Aug 6, 2023
49 tasks
@shi-rudo
Copy link
Contributor Author

shi-rudo commented Aug 6, 2023

Awesome Stock Trading looks pretty good so far - I think there can be a few areas of improvement:

  • Under the books section, the descriptions for each book is kind of long. I think it would be easier to follow (and scroll) if each description was made more succinct (not autogenerating the description with AI).
  • The repository description is kind of long, shorting it would make it more clear at a glance
  • In general, not using AI to autogenerate descriptions, and writing them on your own to be more succinct, clear, and less obtuse
  • It might be a good idea to link youtube channels with videos about stock market trading, kinds of trades one can make, strategies, etc.

Thank you. I took your suggestions to heart and agree with most of what you said.

As for YouTube, I have to confess that I hardly use it, I'm more of a book guy. But I will look in the next few weeks to see if there is any good and substantial material.

@aabouzaid
Copy link
Contributor

aabouzaid commented Aug 7, 2023

@shi-rudo According to the guides, the link and description are separated by a dash. The Most Important Stock Exchanges section doesn't follow that.

@aabouzaid aabouzaid mentioned this pull request Aug 7, 2023
32 tasks
@kfriede
Copy link

kfriede commented Aug 18, 2023

I'd recommend adding a space between your heading and the awesome badge

@kfriede kfriede mentioned this pull request Aug 18, 2023
33 tasks
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ghu44//yr6gg-&#//

@sindresorhus
Copy link
Owner

❯ awesome-lint https://github.com/shi-rudo/awesome-stock-trading
✖ Linting

  README.md:92:61
  ✖  92:61  List item description must start with valid casing  remark-lint:awesome-list-item
  ✖  93:64  List item description must start with valid casing  remark-lint:awesome-list-item

  2 errors

readme.md Outdated Show resolved Hide resolved
Changed description
@shi-rudo
Copy link
Contributor Author

shi-rudo commented Oct 23, 2023

❯ awesome-lint https://github.com/shi-rudo/awesome-stock-trading
✖ Linting

  README.md:92:61
  ✖  92:61  List item description must start with valid casing  remark-lint:awesome-list-item
  ✖  93:64  List item description must start with valid casing  remark-lint:awesome-list-item

  2 errors

@sindresorhus my awesome-lint v1 does not detect those errors!

 awesome-finance % npx awesome-lint                                                  
✔ Linting

I even checked the lines with position you mentioned. there's nothing wrong? what do I miss?

## Stock Collections
- [Growth 250](https://marketsmith.investors.com/growth250/) - MarketSmith's Growth 250 is a curated list of high-potential stocks.
- [StockTwits Top 10](https://stocktwits.com/rankings/trending) - StockTwits' list of the top 10 trending stocks.

@sindresorhus sindresorhus merged commit 95fef0e into sindresorhus:main Feb 14, 2024
1 check failed
@sindresorhus
Copy link
Owner

Tweet: https://twitter.com/awesome__re/status/1757678455507026166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants