Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow TextLocation to be created #372

Merged
merged 2 commits into from
May 13, 2024

Conversation

migueldeicaza
Copy link
Contributor

There is currently no way of creating a TextLocation from a row, column. Even if that seems to have
been the desire from a previous PR:

#138

This allows me to create TextLocations, which in turn let me gets offsets, which in turn allow me to get screen coordinates from a given position.

@simonbs
Copy link
Owner

simonbs commented May 10, 2024

@migueldeicaza Makes sense to me. I'm happy to merge this once the SwiftLint warning is addressed. I attempted fixing it but it seems that I don't have permission to push to your branch.

@migueldeicaza
Copy link
Contributor Author

Thank you Simon.

I think I fixed the issue; I am not sure why this time it did not let you push to my branch. Apologies for that.

@simonbs simonbs merged commit 81e23a9 into simonbs:main May 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants