Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display book comments at xhtml #491

Open
wants to merge 47 commits into
base: master
Choose a base branch
from

Conversation

SenorSmartyPants
Copy link

convert all comments to xhtml

Not all html elements are detected by the preg_match. These comments then displayed with HTML elements visible.
@horus68
Copy link
Contributor

horus68 commented Nov 26, 2020

Can I ask why is this needed?

Makes typeahead inputs look like bootstrap3
Reference typeahead css
Make bar take full width
only hide labels in sm size
use navbar-static-top. no rounded corners
remove optional bootstrap theme
change HTML thumbnail size to 225
Fix cover-image CSS - drop height attribute
Needed for client side rendering
Only really needed on XS mobile phone view.
Add 3px padding so cover isn't at the very top of display.
@SenorSmartyPants
Copy link
Author

Because without it some comments show up like this...

image

instead of like this

image

@mikespub
Copy link

Included in #522 and release 1.3.0 at https://github.com/mikespub-org/seblucas-cops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants