Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dompurify and ngx-markdown in /desktop/angular #1697

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 16, 2024

Bumps dompurify to 3.1.6 and updates ancestor dependency ngx-markdown. These dependencies need to be updated together.

Updates dompurify from 2.4.3 to 3.1.6

Release notes

Sourced from dompurify's releases.

DOMPurify 3.1.6

  • Fixed an issue with the execution logic of attribute hooks to prevent bypasses, thanks @​kevin-mizu
  • Fixed an issue with element removal leading to uncaught errors through DOM Clobbering, thanks @​realansgar
  • Fixed a minor problem with the bower file pointing to the wrong dist path
  • Fixed several minor typos in docs, comments and comment blocks, thanks @​Rotzbua
  • Updated several development dependencies

DOMPurify 3.1.5

  • Fixed a minor issue with the dist paths in bower.js, thanks @​HakumenNC
  • Fixed a minor issue with sanitizing HTML coming from copy&paste Word content, thanks @​kakao-bishop-cho

DOMPurify 3.1.4

  • Fixed an issue with the recently implemented isNaN checks, thanks @​tulach
  • Added several new popover attributes to allow-list, thanks @​Gigabyte5671
  • Fixed the tests and adjusted the test runner to cover all branches

DOMPurify 3.1.3

  • Fixed several mXSS variations found by and thanks to @​kevin-mizu & @​Ry0taK
  • Added better configurability for comment scrubbing default behavior
  • Added better hardening against Prototype Pollution attacks, thanks @​kevin-mizu
  • Added better handling and readability of the nodeType property, thanks @​ssi02014
  • Fixed some smaller issues in README and other documentation

DOMPurify 3.1.2

  • Addressed and fixed a mXSS variation found by @​kevin-mizu
  • Addressed and fixed a mXSS variation found by Adam Kues of Assetnote
  • Updated tests for older Safari and Chrome versions

DOMPurify 3.1.1

  • Fixed an mXSS sanitiser bypass reported by @​icesfont
  • Added new code to track element nesting depth
  • Added new code to enforce a maximum nesting depth of 255
  • Added coverage tests and necessary clobbering protections

Note that this is a security release and should be upgraded to immediately. Please also note that further releases may follow as the underlying vulnerability is apparently new and further variations may be discovered.

DOMPurify 3.1.0

  • Added new setting SAFE_FOR_XML to enable better control over comment scrubbing
  • Updated README to warn about happy-dom not being safe for use with DOMPurify yet
  • Updated the LICENSE file to show the accurate year number
  • Updated several build and test dependencies

DOMPurify 3.0.11

  • Fixed another conditional bypass caused by Processing Instructions, thanks @​Ry0taK
  • Fixed the regex for HTML Custom Element detection, thanks @​AlekseySolovey3T

DOMPurify 3.0.10

  • Fixed two possible bypasses when sanitizing an XML document and later using it in HTML, thanks @​Slonser
  • Bumped up some build and test dependencies

... (truncated)

Commits
  • 4083a90 Merge pull request #978 from cure53/main
  • 90a10a1 fix: Fixed a typo on the README
  • 65df042 chore: Preparing 3.1.6 release
  • 6e03334 fix: Made sure that remove() is not called directly from node
  • 00fc06c fix: Fixed a DOM clobbering issue leading to an error being thrown
  • f8c2ef5 Merge pull request #977 from cure53/dependabot/npm_and_yarn/multi-99ca4f73d8
  • e5112ec build(deps): bump ws and socket.io-adapter
  • 9978cec docs: Added better security warning about SAFE_FOR_XML to README
  • fa542df fix: Changed the order for attribute checks slightly for safer hooks
  • b8b552c Merge pull request #975 from cure53/dependabot/npm_and_yarn/multi-2d3aef8690
  • Additional commits viewable in compare view

Updates ngx-markdown from 16.0.0 to 18.0.0

Release notes

Sourced from ngx-markdown's releases.

v18.0.0

Update Angular 18

Library has been updated to support Angular 18.

It is recommended to stick with ngx-markdown v17.x.x if you are using Angular 17.

New features and enhancements

  • Update to Angular 18
  • Remove clipboard button inline opacity transition and add CSS classes

⚠️ Breaking changes

Clipboard Plugin

The clipboard button no longer has an opacity transition by default. Instead, CSS classes have been added to allow customization as documented in the README.md and the Plugins > Clipboard Plugin section of the demo site.

To keep the previous behavior, simply add the following CSS to your global styles.css/scss styling file.

.markdown-clipboard-toolbar {
  opacity: 0;
  transition: opacity 250ms ease-out;
}
.markdown-clipboard-toolbar.hover {
opacity: 1;
}

Special thanks

🥇 Thanks to @​pkurcx for his contribution to update Angular 18.

Commits

v17.2.1

Bug Fixes

  • Fix clipboard button when used with katex directive (#515) (73dc926) @​jfcere
  • Fix clipboard uses with Prism coy theme (#516) (3f0172b) @​jfcere

v17.2.0

New features and enhancements

  • Add support for marked >= 9.0.0 < 13.0.0 (#512) (07a9ed5) @​jfcere

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [dompurify](https://github.com/cure53/DOMPurify) to 3.1.6 and updates ancestor dependency [ngx-markdown](https://github.com/jfcere/ngx-markdown). These dependencies need to be updated together.


Updates `dompurify` from 2.4.3 to 3.1.6
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](cure53/DOMPurify@2.4.3...3.1.6)

Updates `ngx-markdown` from 16.0.0 to 18.0.0
- [Release notes](https://github.com/jfcere/ngx-markdown/releases)
- [Commits](jfcere/ngx-markdown@v16.0.0...v18.0.0)

---
updated-dependencies:
- dependency-name: dompurify
  dependency-type: indirect
- dependency-name: ngx-markdown
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies TYPE: update of dependencies javascript Pull requests that update Javascript code labels Sep 16, 2024
Copy link
Contributor

coderabbitai bot commented Sep 16, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@angular/[email protected] None +1 16.2 MB google-wombot
npm/@angular/[email protected] None +2 29 MB google-wombot
npm/@types/[email protected] None 0 57 kB types
npm/@types/[email protected] None 0 1.68 MB types
npm/[email protected] None 0 50 kB typescript-bot

View full report↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies TYPE: update of dependencies javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants