Fix ca-certificates dependency for deb packages #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase. |
mattkeenan
force-pushed
the
fix/issues/91
branch
2 times, most recently
from
9210c2d
to
d57dc41
Compare
|
Sorry, I'm far more used to the git command line than github. Rebased to safing/develop. |
dhaavi
approved these changes
Jul 21, 2023
|
LGTM, merging. I don't know yet when we will do the next release though - hopefully soon. Thanks for the fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #91. In order to install portmaster files must be downloaded via https, but this requires trusted certificates to be installed or the download will fail because the SSL cert on the server won't be trusted. To fix this we include
ca-certificatesas a dependency (this package is installed on desktop installs). This will be useful on some containers or iot installs, and to a lesser extent minimal server installs (like debootstrap installs).