Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Mapper::map convenience method #136

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add a Mapper::map convenience method #136

wants to merge 2 commits into from

Conversation

phil-opp
Copy link
Member

@phil-opp phil-opp commented Mar 6, 2020

Instead of requiring the caller to specify the target frame, this method uses a frame allocated from the frame allocator. This makes the common use case of mapping a page to an unused physical frame more convenient.

Builds upon #135, so there are some additional commits in this PR. I will rebase it as soon as #135 is merged.

@josephlr
Copy link
Contributor

@phil-opp this looks reasonable to me. If you rebase, I can review.

@phil-opp phil-opp marked this pull request as ready for review October 18, 2020 09:54
@phil-opp
Copy link
Member Author

Rebased

@phil-opp phil-opp added the waiting-for-review Waiting for a review from the maintainers. label Dec 28, 2020
Copy link
Member

@mental32 mental32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mental32
Copy link
Member

@josephlr (friendly ping :D) do you have any comments?

@Freax13 Freax13 mentioned this pull request Jun 7, 2021
@josephlr
Copy link
Contributor

@phil-opp sorry for missing this, will review this, #266, and #264 to figure out which mapping improvements we want.

@phil-opp
Copy link
Member Author

@josephlr Thanks a lot! The past weeks have been busy for me, so I haven't had time to review these PRs yet. Feel free to ping me if you need any input from me.

@phil-opp
Copy link
Member Author

phil-opp commented Sep 4, 2021

@josephlr Do you have time for a quick review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-review Waiting for a review from the maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants