Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Initial proposal for CancellableOneShot #124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chrysn
Copy link
Contributor

@chrysn chrysn commented Jan 31, 2019

Add a trait that extends OneShot and allows cancellation, along with an incomplete example.

This is a first shot at #123; not ready for review as in "ensure we can merge this", but pushed into a PR to have actual discussion material in #123.

Add a trait that extends OneShot and allows cancellation, along with an
incomplete example.
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@therealprof
Copy link
Contributor

... but does not compile:

122 | pub trait CancellableOneShot<ADC, Word, Pin: Channel<ADC>>: OneShot<ADC, Word, Pin, Channel<ADC>> {
    |                                                                                     ^^^^^^^^^^^^ unexpected type argument

@chrysn
Copy link
Contributor Author

chrysn commented Jan 31, 2019

Oups, tested without the unproven feature.

Fixed, and cargo +nightly test --features unproven now runs through the test as well after having ironed out the details.

@Disasm Disasm added S-waiting-on-author Author needs to make changes to address reviewer comments T-hal labels Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Author needs to make changes to address reviewer comments T-hal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants