Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Event Logs source #30

Merged
merged 11 commits into from
Sep 2, 2023
Merged

Windows Event Logs source #30

merged 11 commits into from
Sep 2, 2023

Conversation

harpesichord
Copy link
Contributor

This source will only work on windows machines and is only included in the windows built.

It reads the event log stream based on the channel and query provided.

@harpesichord
Copy link
Contributor Author

@abraithwaite I had a question about this. Let me know when you have some free time and I can walk you through it and get some clarification. It works if you run the windows exe as an admin. But it would be beneficial to add commands to install it as a service.

Copy link
Contributor

@abraithwaite abraithwaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just need to figure out the build then let's merge it :-)

@harpesichord
Copy link
Contributor Author

harpesichord commented Aug 30, 2023

Looks great! Just need to figure out the build then let's merge it :-)

@abraithwaite
So I added this to the 3 files. And lint of course skips them. So, not sure if we need to do something to update the build to account for that.

//go:build windows
// +build windows

I think it was failing because one of the files uses a package that is specific to windows and so it wasn't getting included in the build and then it caused the others to fail.

@abraithwaite
Copy link
Contributor

I haven't tried this yet, but we could potentially add a windows build configuration to the build matrix for github actions. I don't think it's too critical right now though. If someone picks this up, hopefully they'll report any issues they encounter.

@harpesichord harpesichord marked this pull request as ready for review September 2, 2023 15:00
@harpesichord harpesichord merged commit 80b7ad6 into main Sep 2, 2023
1 check passed
@harpesichord harpesichord deleted the harpe/windows-events branch September 2, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants