Skip to content

Commit

Permalink
Merge pull request #50 from runreveal/alan/batcher-updates
Browse files Browse the repository at this point in the history
ErrorHandle -> ErrorFunc
  • Loading branch information
abraithwaite committed Jul 4, 2024
2 parents f35e373 + 5ba0d4c commit 38ee1e5
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions x/batcher/batcher.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ type ErrorHandler[T any] interface {
HandleError(context.Context, error, []kawa.Message[T]) error
}

type ErrorHandle[T any] func(context.Context, error, []kawa.Message[T]) error
type ErrorFunc[T any] func(context.Context, error, []kawa.Message[T]) error

func (ef ErrorHandle[T]) HandleError(c context.Context, err error, msgs []kawa.Message[T]) error {
func (ef ErrorFunc[T]) HandleError(c context.Context, err error, msgs []kawa.Message[T]) error {
return ef(c, err, msgs)
}

Expand Down Expand Up @@ -94,11 +94,11 @@ func StopTimeout(d time.Duration) func(*Opts) {
}

func DiscardHandler[T any]() ErrorHandler[T] {
return ErrorHandle[T](func(context.Context, error, []kawa.Message[T]) error { return nil })
return ErrorFunc[T](func(context.Context, error, []kawa.Message[T]) error { return nil })
}

func Raise[T any]() ErrorHandler[T] {
return ErrorHandle[T](func(_ context.Context, err error, _ []kawa.Message[T]) error { return err })
return ErrorFunc[T](func(_ context.Context, err error, _ []kawa.Message[T]) error { return err })
}

// NewDestination instantiates a new batcher.
Expand Down
4 changes: 2 additions & 2 deletions x/batcher/batcher_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ func TestBatcherErrors(t *testing.T) {
time.Sleep(110 * time.Millisecond)
return flushErr
}
var errHandler = ErrorHandle[string](func(c context.Context, err error, msgs []kawa.Message[string]) error {
var errHandler = ErrorFunc[string](func(c context.Context, err error, msgs []kawa.Message[string]) error {
assert.ErrorIs(t, err, flushErr)
return err
})
Expand Down Expand Up @@ -263,7 +263,7 @@ func TestBatcherErrors(t *testing.T) {
time.Sleep(110 * time.Millisecond)
return flushErr
}
var errHandler = ErrorHandle[string](func(c context.Context, err error, msgs []kawa.Message[string]) error {
var errHandler = ErrorFunc[string](func(c context.Context, err error, msgs []kawa.Message[string]) error {
assert.ErrorIs(t, err, flushErr)
return err
})
Expand Down

0 comments on commit 38ee1e5

Please sign in to comment.